Skip to content

.cargo: check all features in custom-clippy#2771

Merged
mxinden merged 3 commits intolibp2p:masterfrom
elenaf9:clippy-all-features
Jul 28, 2022
Merged

.cargo: check all features in custom-clippy#2771
mxinden merged 3 commits intolibp2p:masterfrom
elenaf9:clippy-all-features

Conversation

@elenaf9
Copy link
Copy Markdown
Member

@elenaf9 elenaf9 commented Jul 24, 2022 •
edited
Loading

Description

Our custom-clippy currently just runs clippy with the default features. The result of this is that a) not all packages are checked, and b) all features in those packages are disabled. This caused issues like #2770 and #2737.
Extended it now to check all features.

Depends on:

@elenaf9 elenaf9 mentioned this pull request Jul 24, 2022
Merged
@elenaf9
Copy link
Copy Markdown
Member Author

elenaf9 commented Jul 25, 2022 •
edited
Loading

As an aside: while reading through the cargo book i stumbled across the following note on rust workspaces: https://doc.rust-lang.org/cargo/reference/workspaces.html#the-workspace-section

All path dependencies residing in the workspace directory automatically become members.

Apart from some of the packages in /misc, I think all of our [workspace] members that we currently explicitly list are already path dependencies. I don't really have a strong opinion in this, but theoretically we could remove them from the members list, which makes it one place less to worry about when adding a new package. Wdyt @thomaseizinger @mxinden? Are there any other packages in our workspace that are not path dependencies?

@thomaseizinger
Copy link
Copy Markdown
Contributor

thomaseizinger commented Jul 25, 2022

Interesting, I didn't know that. Happy to remove them from the members list then :)

mxinden
mxinden approved these changes Jul 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Thanks for investigating.

@mxinden
Copy link
Copy Markdown
Member

mxinden commented Jul 27, 2022

@elenaf9 would you mind addressing the remaining clippy failures?

@elenaf9
Copy link
Copy Markdown
Member Author

elenaf9 commented Jul 27, 2022

@elenaf9 would you mind addressing the remaining clippy failures?

@mxinden #2772 🙂

@mxinden
Copy link
Copy Markdown
Member

mxinden commented Jul 28, 2022

Oh, sorry for missing #2772 @elenaf9.

@mxinden mxinden merged commit eaf3f3a into libp2p:master Jul 28, 2022
@elenaf9 elenaf9 deleted the clippy-all-features branch July 28, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@mxinden mxinden mxinden approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elenaf9 @thomaseizinger @mxinden